This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Throw Exception if IsSkillClaim and ClaimsValidator is null#4570
Merged
EricDahlvang merged 1 commit intomainfrom Sep 3, 2020
Merged
Throw Exception if IsSkillClaim and ClaimsValidator is null#4570EricDahlvang merged 1 commit intomainfrom
EricDahlvang merged 1 commit intomainfrom
Conversation
BruceHaley
approved these changes
Sep 3, 2020
gabog
approved these changes
Sep 3, 2020
Contributor
gabog
left a comment
gabog
left a comment
There was a problem hiding this comment.
It would be nice to add tests but we can skip that given the urgency of this change.
Member
Author
|
@gabog i've created an issue to track adding some test for this: https://github.com/microsoft/botbuilder-dotnet/issues/4578 |
EricDahlvang
added a commit
that referenced
this pull request
Sep 3, 2020
EricDahlvang
added a commit
that referenced
this pull request
Sep 3, 2020
EricDahlvang
added a commit
that referenced
this pull request
Sep 3, 2020
EricDahlvang
added a commit
that referenced
this pull request
Sep 3, 2020
mrivera-ms
pushed a commit
that referenced
this pull request
Sep 3, 2020
EricDahlvang
added a commit
that referenced
this pull request
Sep 3, 2020
EricDahlvang
added a commit
that referenced
this pull request
Sep 3, 2020
EricDahlvang
added a commit
that referenced
this pull request
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.