Fix LuisAdapterRecognizer by correctly cloning the temporary TurnContext for adaptiing to legacy LuisRecognizer #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2020 11:53
…t mapping in legacy luisrecognizer implementation.
tomlm
requested review from
chrimc62,
gabog,
johnataylor and
a team
as code owners
tomlm
changed the title
gabog
reviewed
Aug 31, 2020
gabog
reviewed
Aug 31, 2020
gabog
reviewed
Aug 31, 2020
libraries/Microsoft.Bot.Builder.AI.LUIS/LuisAdaptiveRecognizer.cs
Outdated
Show resolved
Hide resolved
chrimc62
reviewed
Sep 1, 2020
libraries/Microsoft.Bot.Builder.AI.LUIS/Schemas/Microsoft.LuisRecognizer.schema
Outdated
Show resolved
Hide resolved
gabog
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4536
Description
added TurnContext ctor which takes TurnContext to clone from and activity and which maintains all properties.
Testing
added tests