This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Fixes Unauthorized error when calling ContinueConversation#4348
Merged
cleemullins merged 5 commits intomasterfrom Jul 30, 2020
Merged
Fixes Unauthorized error when calling ContinueConversation#4348cleemullins merged 5 commits intomasterfrom
cleemullins merged 5 commits intomasterfrom
Conversation
… app service instance that didn't originate the skill request. Made TrustedHostNames in AppCredentials internal and added InternalsVisibleTo directive to Microsoft.BotConnector so we can access it and assert the state of the state in tests. Cleaned up some async warnings in BotFrameworkAdapterTests Added additional logging to AppCredentials to help troubleshoot this issue in the future.
gabog
requested review from
carlosscastro,
johnataylor and
mrivera-ms
as code owners
carlosscastro
approved these changes
Jul 30, 2020
stevengum
reviewed
Jul 30, 2020
stevengum
reviewed
Jul 30, 2020
Member
stevengum
left a comment
stevengum
left a comment
There was a problem hiding this comment.
Not aiming to block the PR, but does the new code path work with bot-to-channel proactive messaging?
stevengum
approved these changes
Jul 30, 2020
mrivera-ms
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4347
Fixes Unauthorized error when ContinueConversation is called on a bot app service instance that didn't originate the skill request.