-
Notifications
You must be signed in to change notification settings - Fork 494
Emit better error messages for all dialogs #4153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@johnataylor should weigh in as we just had a discussion today about not creating custom exception classes. #Resolved |
… with dialog context metadata.
I agree, wrapping is not a good approach, I have switched to using Exception.Data to add metadata about context of exception. In reply to: 647899206 [](ancestors = 647899206) |
cleemullins
approved these changes
Jul 1, 2020
@tomlm CAn you resolve the merge conflicts? |
carlosscastro
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3980
Description
Change dialogContext to capture exceptions and annotate exception with contextual information about where the exception happened.
Specific Changes
Testing
Example exception metadata