This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[LG] Remove dash in identifier to make sure arithmetic expressions can be parsed correctly#3712
Merged
[LG] Remove dash in identifier to make sure arithmetic expressions can be parsed correctly#3712
Conversation
Danieladu
reviewed
Apr 9, 2020
boydc2014
approved these changes
Apr 9, 2020
This was referenced Apr 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #3695
In this PR, identifier can not contain '-'. Template name should not use 'bfactivity-1123'.
This change will make sure expressions like 'user.a-user.b' can be recognize as an arithmetic opration rather than an identifier.