cache Antlr parse result #3621
Merged
cache Antlr parse result #3621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydc2014
reviewed
Mar 26, 2020
boydc2014
reviewed
Mar 26, 2020
libraries/Microsoft.Bot.Builder.LanguageGeneration/TemplatesParser.cs
Outdated
Show resolved
Hide resolved
boydc2014
reviewed
Mar 26, 2020
libraries/Microsoft.Bot.Builder.LanguageGeneration/TemplatesParser.cs
Outdated
Show resolved
Hide resolved
Danieladu
force-pushed
the
hond/parse-perf
branch
from
8d266ee to
52beef3
Compare
boydc2014
approved these changes
Mar 27, 2020
This was referenced Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import chain of LG file is like a graph, there may be various reference logic.
Antlr's parse takes a lot of time in it, If LG SDK can cache the results of Antlr parse(single call life cycle), the performance will be greatly improved.
After experiments, it can save more than half of time for complex lg call chain.
issue link: microsoft/BotFramework-Composer#2374