Skip to content

Move DeepEquals and References from extensions to Expression class #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2020
Merged

Move DeepEquals and References from extensions to Expression class #3588

merged 3 commits into from
Mar 19, 2020

Conversation

@Danieladu
Copy link
Contributor

@Danieladu Danieladu commented Mar 18, 2020

close: #3519
Move the method DeepEquals and References from extensions to Expression class.

@Danieladu Danieladu requested review from boydc2014 and chrimc62 March 18, 2020 09:48
@Danieladu Danieladu requested a review from cosmicshuai March 19, 2020 03:16
@Danieladu Danieladu merged commit 2ee51f7 into master Mar 19, 2020
@Danieladu Danieladu deleted the hond/expression-extension branch March 19, 2020 06:59
This was referenced Mar 19, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@boydc2014 boydc2014 Awaiting requested review from boydc2014

1 more reviewer

@cosmicshuai cosmicshuai cosmicshuai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expression extensions should be defined on Expression class

3 participants

@Danieladu @cosmicshuai