Add 'ephemeral' as the list of options for Delivery Mode #3502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -349,7 +349,10 @@ private async Task SendOAuthCardAsync(ITurnContext turnContext, IMessageActivity | |||
|
|
|||
| if (turnContext.TurnState.Get<ClaimsIdentity>("BotIdentity") is ClaimsIdentity botIdentity && SkillValidation.IsSkillClaim(botIdentity.Claims)) | |||
| { | |||
| cardActionType = ActionTypes.OpenUrl; | |||
| if (turnContext.Activity.ChannelId == "emulator") | |||
There was a problem hiding this comment.
constant, we already have one
There was a problem hiding this comment.
Suggested change
| if (turnContext.Activity.ChannelId == "emulator") | |
| if (turnContext.Activity.ChannelId == Channels.Emulator) | |
|
Approved but Jeff will fix the constant and do some merges |
carlosscastro
approved these changes
Mar 6, 2020
This was referenced Mar 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding a new option for DeliveryMode on the Activity. This property is a string, and the code comment lists all of the possible values. I have updated the code comment to list the new value of 'ephemeral'.