Add support for SSO to parent and child bot projects for manual testing #3489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
swagatmishra2007
commented
Mar 4, 2020
swagatmishra2007
commented
- Add support for SSO to parent and child bot projects for manual testing
- Fixed a minor bug in oauthprompt
carlosscastro
approved these changes
Mar 4, 2020
| await this.SendInvokeResponseAsync( | ||
| turnContext, | ||
| cancellationToken, | ||
| HttpStatusCode.BadRequest, |
There was a problem hiding this comment.
Please confirm with @Jeffders that we can remove this. #Resolved
tests/Skills/Parent/ParentBot.cs
Outdated
| cancellationToken); | ||
|
|
||
| // Check response status: true if success, false if failure | ||
| var success = response.Status >= 200 && response.Status <= 299; |
There was a problem hiding this comment.
IsSuccessstatusCode #Resolved
|
Approved but please check in person with @Jeffders as of why he added that codepath. The fact that there is a test indicates that it is on purpose, so there might be some scenario that we are missing. #Resolved |
swagatmishra2007
commented
Mar 5, 2020
| ConnectionName = _settings.ConnectionName, | ||
| FailureDetail = "The bot received an InvokeActivity with a TokenExchangeInvokeRequest containing a ConnectionName that does not match the ConnectionName expected by the bot's active OAuthPrompt. Ensure these names match when sending the InvokeActivityInvalid ConnectionName in the TokenExchangeInvokeRequest", | ||
| }).ConfigureAwait(false); | ||
| } |
There was a problem hiding this comment.
revert #Resolved
This was referenced Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.