[QnAMaker] GetAnswerRaw added #2512
Conversation
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
| /// <param name="options">The options for the QnA Maker knowledge base. If null, constructor option is used for this instance.</param> | ||
| /// <returns>A list of answers for the user query, sorted in decreasing order of ranking score.</returns> | ||
| public async Task<QueryResult[]> GetAnswersAsync(ITurnContext turnContext, IMessageActivity messageActivity, QnAMakerOptions options) | ||
| public async Task<QueryResults> GetAnswersAsync(ITurnContext turnContext, IMessageActivity messageActivity, QnAMakerOptions options) |
There was a problem hiding this comment.
Can't make this change due to compatablity concerns. Leave this old method in place, and create a new one.
Public method / public class....
There was a problem hiding this comment.
This methods is not used anywhere. Everyone calls GetAnswersAsync method present in QnAMaker.cs file.
There was a problem hiding this comment.
This is a public method on a public class, which means compat needs to be preserved. That's a hard requirement that we've got.
If needed, you can put an obsolete attribute on the old method and introduce a new one.
| /// <param name="options">The options for the QnA Maker knowledge base. If null, constructor option is used for this instance.</param> | ||
| /// <returns>A list of answers for the user query, sorted in decreasing order of ranking score.</returns> | ||
| public async Task<QueryResult[]> GetAnswersAsync(ITurnContext turnContext, IMessageActivity messageActivity, QnAMakerOptions options) | ||
| public async Task<QueryResults> GetAnswersAsync(ITurnContext turnContext, IMessageActivity messageActivity, QnAMakerOptions options) |
There was a problem hiding this comment.
This is a public method on a public class, which means compat needs to be preserved. That's a hard requirement that we've got.
If needed, you can put an obsolete attribute on the old method and introduce a new one.
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
Added Active learning enabled flag support
Tests added for that.