Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@gabog
Copy link
Contributor

@gabog gabog commented Jun 11, 2019

This PR implements DCR: https://github.com/microsoft/botbuilder-dotnet/issues/2028

Main changes incude:

  • Created new Microsoft.Builder.Testing and Microsoft.Builder.Testing.Tests projects.
  • Microsoft.Builder.Testing cotains three new classes:
    • DialogTestClient: this classes allows your to test dialogs in isolation.
    • XUnitOutputMiddleware a helper middleware that outputs incoming and outgoing activities to the console for XUnit based tests.
    • TestDataObject this is a helper classses that will be used with XUnit theory tests and supports serializing complex objects in a way that the XUnit tests runner can use them

gabog added 4 commits June 6, 2019 20:53
Added Microsoft.Bot.Builder.Testing project.
Added Microsoft.Bot.Builder.Testing.Tests project.
Created DialogTestClient, XUnitOutputMiddleware TestDataObject and related tests.
@gabog gabog requested review from cleemullins and johnataylor June 11, 2019 19:46
@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2019

Pull Request Test Coverage Report for Build 63989

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.195%

Totals Coverage Status
Change from base Build 63617: 0.03%
Covered Lines: 4350
Relevant Lines: 6110

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit 01ad874 into master Jun 12, 2019
@tomlm tomlm deleted the gabog/InitialDialogTestClient branch June 12, 2019 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants