Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@EricDahlvang
Copy link
Member

@EricDahlvang EricDahlvang commented Jun 7, 2019

Fixes #1944

@EricDahlvang EricDahlvang requested a review from cleemullins June 7, 2019 00:10
@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2019

Pull Request Test Coverage Report for Build 63253

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.155%

Totals Coverage Status
Change from base Build 63235: 0.0%
Covered Lines: 4344
Relevant Lines: 6105

💛 - Coveralls

@fuselabs
Copy link
Collaborator

fuselabs commented Jun 7, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
❌ 2 Binary Compatibility issues for Microsoft.Bot.Schema

Details
MembersMustExist : Member 'Microsoft.Bot.Schema.Activity..ctor(System.String, System.String, System.Nullable<System.DateTimeOffset>, System.Nullable<System.DateTimeOffset>, System.String, System.String, Microsoft.Bot.Schema.ChannelAccount, Microsoft.Bot.Schema.ConversationAccount, Microsoft.Bot.Schema.ChannelAccount, System.String, System.String, System.Collections.Generic.IList<Microsoft.Bot.Schema.ChannelAccount>, System.Collections.Generic.IList<Microsoft.Bot.Schema.ChannelAccount>, System.Collections.Generic.IList<Microsoft.Bot.Schema.MessageReaction>, System.Collections.Generic.IList<Microsoft.Bot.Schema.MessageReaction>, System.String, System.Nullable<System.Boolean>, System.String, System.String, System.String, System.String, System.String, Microsoft.Bot.Schema.SuggestedActions, System.Collections.Generic.IList<Microsoft.Bot.Schema.Attachment>, System.Collections.Generic.IList<Microsoft.Bot.Schema.Entity>, System.Object, System.String, System.String, System.String, System.String, System.Object, System.String, Microsoft.Bot.Schema.ConversationReference, System.String, System.Nullable<System.DateTimeOffset>, System.String, System.String, System.Collections.Generic.IList<System.String>, System.Collections.Generic.IList<Microsoft.Bot.Schema.TextHighlight>, Microsoft.Bot.Schema.SemanticAction, System.String)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'Microsoft.Bot.Schema.SemanticAction..ctor(System.String, System.Collections.Generic.IDictionary<System.String, Microsoft.Bot.Schema.Entity>)' does not exist in the implementation but it does exist in the contract.

@EricDahlvang EricDahlvang requested a review from cleemullins June 7, 2019 03:32
@fuselabs
Copy link
Collaborator

fuselabs commented Jun 7, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cleemullins cleemullins merged commit 9c6e633 into master Jun 12, 2019
@cleemullins cleemullins deleted the eric/swaggerUpdates branch June 12, 2019 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add State to Semantic Actions in Schema

6 participants