This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Made OnTurn method on TelemetryLoggerMiddleware virtual #1862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@garypretty This looks fine to me. @daveta? |
cleemullins
approved these changes
May 16, 2019
Contributor
|
Executive decision, as @daveta hasn't chimed in. Approved! :) |
Contributor
Author
|
Cheers @cleemullins 👍 |
daveta
reviewed
May 16, 2019
Contributor
daveta
left a comment
daveta
left a comment
There was a problem hiding this comment.
Nice! Thanks @garypretty !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @daveta - adding virtual to OnTurn method to allow override. This can then be used to enable logging of information from the context, such as TurnState.