Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@johnataylor
Copy link
Member

add NumberOfAttempts to PromptOptions
fixes microsoft/BotBuilder-Samples#1257

@johnataylor johnataylor added 4.4 April 15, 2019 Release Parity with JS Required labels Apr 10, 2019
@johnataylor johnataylor requested a review from cleemullins April 10, 2019 22:32
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 54024

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 76.186%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/Prompt.cs 4 82.0%
Totals Coverage Status
Change from base Build 53863: 0.03%
Covered Lines: 4402
Relevant Lines: 5778

💛 - Coveralls

@cleemullins
Copy link
Contributor

No issues found in Microsoft.Bot.Builder.dll
No issues found in Microsoft.Bot.Builder.AI.Luis.dll
No issues found in Microsoft.Bot.Builder.AI.QnA.dll
No issues found in Microsoft.Bot.Builder.ApplicationInsights.dll
No issues found in Microsoft.Bot.Builder.Azure.dll
No issues found in Microsoft.Bot.Builder.Dialogs.dll
No issues found in Microsoft.Bot.Builder.TemplateManager.dll
No issues found in Microsoft.Bot.Configuration.dll
No issues found in Microsoft.Bot.Connector.dll
No issues found in Microsoft.Bot.Schema.dll

@johnataylor johnataylor merged commit 8699569 into master Apr 11, 2019
@johnataylor johnataylor deleted the johtaylo/issue1257 branch April 11, 2019 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4.4 April 15, 2019 Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Know the number of attempts inside a validation

4 participants