Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+159
to
+166
| foreach (string import in target.PE.Imports) | ||
| { | ||
| if (import.StartsWith("clang_rt.asan_", StringComparison.OrdinalIgnoreCase) && | ||
| import.EndsWith(".dll", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| return true; | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A naive attempt at tackling: #981
Context:
The MSVC ASan team is tracking ASan usage information through BinSkim.
This PR attempts to generate telemetry containing whether an analyzed binary (.dll or .exe) is linked against one of the ASan dlls.
Next Steps:
To my knowledge, have yet to have an official conversation with BinSkim about this, so there's no real reason to merge or review this yet. I just wanted to create this PR as a 'best effort' attempt at prototyping the change. I'll look to try and drive that conversation internally so I can either abandon this PR, or officially publish it. Thank you!