Skip to content

Conversation

@radium-v
Copy link
Contributor

@radium-v radium-v commented May 9, 2022

This PR is a re-up of #633 by @PorterNan, which fixes the failing e2e test.

From the original PR:

This PR is to fix the logic of prerelease tag not working.
According to api doc from semver, prerelease bump should be like this:
https://www.npmjs.com/package/semver#:~:text=semver.inc(%271.2.3%27%2C%20%27prerelease%27%2C%20%27beta%27)

This change will allow beachball to call semver using 'prerelease' parameter to do a correct prerelease bump

@awentzel
Copy link

Hi @kenotron do you have time to review? We're on a tight schedule to release with pre-release versioning. Thanks

@EisenbergEffect
Copy link

Pretty please @kenotron 🥺

@awentzel
Copy link

Pinging all maintainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prerelease flag not working, probably a wrong api call to semver

4 participants