Temporarily revert npm-registry-fetch usage #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ecraig12345
force-pushed
the
ecraig/revert-npm-fetch
branch
from
cb407cb to
6f6c5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1114 switched to using
npm-registry-fetchinstead of the npm CLI for fetching package info. Unfortunately, due to Beachball's current Node 14 minbar, it was necessary to use an oldnpm-registry-fetchversion, which pulls in an oldtarversion where a major vulnerability was recently discovered.This PR reverts to using npm CLI for now, in the interest of providing a security fix without a major bump. (#1143 tracks reverting the revert.)