-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CVE 2024-24790 for golang and backport the fix to golang 1.18 #9786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrw
reviewed
Jul 11, 2024
mfrw
reviewed
Jul 15, 2024
bhagyapathak
force-pushed
the
bhagya/CVE-2024-24790
branch
from
July 15, 2024 06:02
b03d9cb
to
bf20c9e
Compare
bhagyapathak
force-pushed
the
bhagya/CVE-2024-24790
branch
from
July 15, 2024 06:17
bf20c9e
to
b5cf9fe
Compare
mfrw
reviewed
Jul 15, 2024
PawelWMS
reviewed
Jul 15, 2024
PawelWMS
reviewed
Jul 15, 2024
PawelWMS
reviewed
Jul 15, 2024
mfrw
reviewed
Jul 16, 2024
bhagyapathak
force-pushed
the
bhagya/CVE-2024-24790
branch
from
July 16, 2024 09:03
f30d449
to
4659a71
Compare
PawelWMS
reviewed
Jul 16, 2024
PawelWMS
reviewed
Jul 16, 2024
PawelWMS
reviewed
Jul 16, 2024
PawelWMS
approved these changes
Jul 18, 2024
mfrw
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Thanks for patiently addressing the comments.
jslobodzian
approved these changes
Jul 25, 2024
13 tasks
Opted to just take the golang fix. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./SPECS/LICENSES-AND-NOTICES/data/licenses.json
,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md
,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
This PR fix the CVE-2024-24790 for golang
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
https://nvd.nist.gov/vuln/detail/CVE-2024-24790
Test Methodology
golang 1.18 Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=602940&view=results
golang Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=605230&view=results