Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE 2024-24790 for golang and backport the fix to golang 1.18 #9786

Closed
wants to merge 24 commits into from

Conversation

bhagyapathak
Copy link
Contributor

@bhagyapathak bhagyapathak commented Jul 11, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • [ x] The toolchain has been rebuilt successfully (or no changes were made to it)
  • [ x] The toolchain/worker package manifests are up-to-date
  • [ x] Any updated packages successfully build (or no packages were changed)
  • [x ] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • [ x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • [ x] All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • [ x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • [x ] All source files have up-to-date hashes in the *.signatures.json files
  • [x ] sudo make go-tidy-all and sudo make go-test-coverage pass
  • [ x] Documentation has been updated to match any changes to the build system
  • [x ] If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
  • [ x] Ready to merge

Summary

This PR fix the CVE-2024-24790 for golang

Change Log
  • Upgrade golang 1.21 to 1.22
  • Backport fix to golang 1.18
  • Bump release version of all packages using golang & golang1.18
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-24790

Test Methodology

@bhagyapathak bhagyapathak requested a review from a team as a code owner July 11, 2024 06:27
SPECS/golang/golang.spec Outdated Show resolved Hide resolved
@mfrw mfrw added security fasttrack/2.0 PRs Destined for AzureLinux 2.0 labels Jul 11, 2024
@bhagyapathak bhagyapathak requested a review from mfrw July 12, 2024 08:58
SPECS/golang/golang.spec Outdated Show resolved Hide resolved
SPECS/golang/golang.spec Outdated Show resolved Hide resolved
cgmanifest.json Outdated Show resolved Hide resolved
SPECS/golang/golang.spec Outdated Show resolved Hide resolved
SPECS/golang/golang.spec Outdated Show resolved Hide resolved
SPECS/golang/golang.spec Outdated Show resolved Hide resolved
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Thanks for patiently addressing the comments.

@mfrw mfrw mentioned this pull request Jul 19, 2024
13 tasks
@jslobodzian
Copy link
Contributor

Opted to just take the golang fix. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fasttrack/2.0 PRs Destined for AzureLinux 2.0 security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants