-
Notifications
You must be signed in to change notification settings - Fork 603
[AutoPR- Security] Patch libpcap for CVE-2025-11961 [LOW] #15434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoPR- Security] Patch libpcap for CVE-2025-11961 [LOW] #15434
Conversation
|
Buddy Build link : https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1019788&view=results Buddy Build result is successful |
mfrw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Patch applies cleanly
- Patch looks good w.r.t upstream
- Test build passes
- Signed-Off By: @mfrw
| - register u_char *ep, *e; | ||
| - register u_char d; | ||
| + uint8_t tmp[6]; | ||
| + if (! pcapint_atomac48(s, tmp)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks good w.r.t upstream
kgodara912
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing in favour of #15807 due minor duplication and straight away application of patch.
| Source0: %{name}-%{name}-%{version}.tar.gz | ||
| Patch0: CVE-2024-8006.patch | ||
| Patch1: CVE-2023-7256.patch | ||
| Patch2: CVE-2025-11961.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: mixed indentation.
|
|
||
| +/* Hex digit to 8-bit unsigned integer. */ | ||
| +static inline u_char | ||
| +pcapint_xdtoi(u_char c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a separate function in the file. It was a renaming of the existing function, but AI was unaware about the context and created a function with duplicate body which is not needed.
Auto Patch libpcap for CVE-2025-11961.
Autosec pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1018858&view=results
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology