Skip to content

Patch luajit for CVE-2024-25177[HIGH] #14436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 15, 2025

Conversation

kgodara912
Copy link
Contributor

@kgodara912 kgodara912 commented Aug 5, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Added patch for CVE-2024-25177

Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/2.0 PRs Destined for Azure Linux 2.0 labels Aug 5, 2025
@kgodara912 kgodara912 marked this pull request as ready for review August 5, 2025 11:28
@kgodara912 kgodara912 requested a review from a team as a code owner August 5, 2025 11:28
@realsdx
Copy link
Contributor

realsdx commented Aug 11, 2025

this link https://luajit.org/download/LuaJIT-2.1.0-beta3.tar.gz is dead, maybe we can use the github one?

@Sumynwa
Copy link
Contributor

Sumynwa commented Aug 11, 2025

this link https://luajit.org/download/LuaJIT-2.1.0-beta3.tar.gz is dead, maybe we can use the github one?

Yes, please use the github link.

@Kanishk-Bansal
Copy link
Contributor

We can use https://github.com/LuaJIT/LuaJIT/archive/refs/tags/v2.1.0-beta3.tar.gz

@kgodara912
Copy link
Contributor Author

The above has different signature compared to what we have already due to .gitignore in source tree, except that everything else is same. I will rename existing source tree and will update signature for the file.

Updating new reference for LuaJit.
Updated source URL with valid upstream reference.
Updated signature file as well.
Updated signature values.
@kgodara912
Copy link
Contributor Author

kgodara912 commented Aug 12, 2025

Updated buddy build

Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch Analysis (the patch applies cleanly wrt t upstream)

there was a check failing due to which we updated the signature and cgmanifest as the older link was giving a 404 error

  • Buddy Build 
  • patch applied during the build (check rpm.log)
  • patch include an upstream reference
  • PR has security tag

@Kanishk-Bansal Kanishk-Bansal added the CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review label Aug 12, 2025
@PawelWMS PawelWMS removed the CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review label Aug 13, 2025
@Kanishk-Bansal Kanishk-Bansal added the CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review label Aug 14, 2025
@PawelWMS PawelWMS merged commit 40c76f2 into fasttrack/2.0 Aug 15, 2025
25 of 28 checks passed
@PawelWMS PawelWMS deleted the kgodara/fasttrack/2.0/luajit/CVE-2024-25177 branch August 15, 2025 18:42
CBL-Mariner-Bot pushed a commit that referenced this pull request Aug 15, 2025
Co-authored-by: Kshitiz Godara <kgodara@microsoft.com>
Co-authored-by: Kanishk Bansal <103916909+Kanishk-Bansal@users.noreply.github.com>
(cherry picked from commit 40c76f2)
@CBL-Mariner-Bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review fasttrack/2.0 PRs Destined for Azure Linux 2.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants