Skip to content

[Medium]: Patch to upgrade llhttp from v6.1.1 to v9.1.2 to address CVE-2025-23167 #14352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

durgajagadeesh
Copy link
Contributor

@durgajagadeesh durgajagadeesh commented Jul 21, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary
Change Log
  • Modified file: nodejs18.spec
  • New file: upgrade_llhttp-v6.1.1_to_llhttp-v9.1.2.patch
  • New file: update_callBack_pointers_in_llhttp_settings_t_structure_fix_http_parser_error.patch
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
image

@durgajagadeesh durgajagadeesh requested a review from a team as a code owner July 21, 2025 03:56
@durgajagadeesh durgajagadeesh marked this pull request as draft July 21, 2025 04:36
@Kanishk-Bansal
Copy link
Contributor

Buddy Build

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Jul 22, 2025

Buddy Build

Hi @Kanishk-Bansal,
The build got failed, checking for the failure reason.
image

-Thank you!

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Aug 6, 2025

Hi @Kanishk-Bansal and @kgodara912
I have received the security test logs from the MSRC team.
Based on these results, Abhilash has confirmed that there is no need to apply any additional CVE fix with this upgrade, as the upgraded patch already includes the CVE fix.
Please see the logs below for your reference.

This is the POC abhilash was using : CVE-2025-23167 : HTTP Parser Flaw in Node.js 20 Allows Request Smuggling

Default response without patch :
image

Binary with patch throws HTTP 400:
image

-Thank you!

@durgajagadeesh durgajagadeesh changed the title Upgrade llhttp-v6 to llhttp-v9.1.2 to address CVE-2025-23167 [Medium]: Patch to upgrade llhttp from v6.1.1 to v9.1.2 to address CVE-2025-23167 Aug 6, 2025
@Malateshk007 Malateshk007 requested a review from kgodara912 August 6, 2025 06:15
@durgajagadeesh durgajagadeesh marked this pull request as ready for review August 9, 2025 20:56
@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Aug 9, 2025

@kgodara912,
The patch was applied without issues and has been tested successfully on the local VM.
image

-Thank you!

@Kanishk-Bansal
Copy link
Contributor

Buddy Build

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Aug 12, 2025

Buddy Build

Hi @Kanishk-Bansal and @kgodara912,
The Buddy Build results were passed, and my patch applied successfully as shown in below reference screenshot.
image
image

-Thank you!

@Malateshk007 Malateshk007 requested a review from Sumynwa August 18, 2025 14:13
@Malateshk007
Copy link

@Sumynwa. could you please share your review and signoff on this PR if all good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants