Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use user delegation key to get blobs #25605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sahuroshan
Copy link
Contributor

The current way of getting backup files from storage account was failing if we disable shared key access in storage account . With recent security push we need to disable shared key access for storage accounts. This PR contains the change for using user delegation key to get the backup files , user delegation key method works even if the shared key access is disabled for storage accounts.

ADO task - https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/31210535

Reference code - https://github.com/Azure-Samples/AzureStorageSnippets/blob/master/blobs/howto/JavaScript/NodeJS-v12/dev-guide/list-blobs-from-container-sas-token.js

https://learn.microsoft.com/en-us/azure/storage/common/shared-key-authorization-prevent?tabs=portal#understand-how-disallowing-shared-key-affects-sas-tokens

https://learn.microsoft.com/en-us/azure/storage/common/storage-sas-overview

@kburtram
Copy link
Member

kburtram commented Jul 9, 2024

@sahuroshan are you still working on this PR or should we close it out as abandoned?

@sahuroshan
Copy link
Contributor Author

@sahuroshan are you still working on this PR or should we close it out as abandoned?

Hi @kburtram , This was paused because of security push , we will be starting again on this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants