Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using User Delegation Key to upload ARM templates #25600

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sahuroshan
Copy link
Contributor

We use SAS tokens to upload ARM templates to storage accounts . SAS tokens needs to be signed with either storage account key or user delegation key . Earlier we were using account key , but with recent security push use of account keys is discouraged. This PR contains the change for using user delegation key instead of account keys.

ADO task - https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/3119155

Reference code - https://github.com/Azure-Samples/AzureStorageSnippets/blob/master/blobs/howto/JavaScript/NodeJS-v12/dev-guide/upload-blob-from-blob-sas-token.js

https://learn.microsoft.com/en-us/azure/storage/common/shared-key-authorization-prevent?tabs=portal#understand-how-disallowing-shared-key-affects-sas-tokens

https://learn.microsoft.com/en-us/azure/storage/common/storage-sas-overview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8783588636

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.738%

Totals Coverage Status
Change from base Build 8760396003: 0.0%
Covered Lines: 30720
Relevant Lines: 68884

💛 - Coveralls

@sahuroshan sahuroshan changed the title Using User Delegation Key instead of Account Key to sign SAS URI Using User Delegation Key to upload ARM templates Apr 23, 2024
@kburtram
Copy link
Member

kburtram commented Jul 9, 2024

@sahuroshan are you still working on this PR or should we close it out as abandoned?

@sahuroshan
Copy link
Contributor Author

@sahuroshan are you still working on this PR or should we close it out as abandoned?

Hi @kburtram , We had paused because of security push, we will start this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants