Private endpoints #499
Merged
Private endpoints #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to subnets; add soft delete for key vaults and TLS encryption for storage accounts
cosmos db
use private endpoints
remove unused speech service parameter and add network security group…
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…austomatically pull the app name from azd env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to enhance the security of the Azure Chat application by implementing Private Endpoints. The changes include updates to documentation and infrastructure templates to support the deployment and configuration of these private endpoints.
Key changes include:
Documentation Updates:
docs/10-private-endpoints.md: Added detailed instructions on securing Azure Chat resources with Private Endpoints, including an overview, configuration steps, and additional considerations.docs/4-deploy-to-azure.md: Updated deployment instructions to include prompts for configuring Private Endpoints.Infrastructure Template Updates:
infra/main.bicep: Added parameters and descriptions for enabling/disabling Private Endpoints and configuring related network settings. [1] [2] [3] [4] [5]infra/private_endpoints_core.bicep: Introduced a new template for creating and configuring the virtual network, subnets, and private endpoints for various Azure services.infra/private_endpoints_services.bicep: Added a new template for creating private endpoints and associated DNS zones.infra/resources.bicep: Updated resources to conditionally use private endpoints and disable public network access based on the new parameters. [1] [2] [3] [4] [5] [6] [7] [8] [9]