Skip to content

Fixing NuGetToolInstallerV0 #1793821 #14154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2020
Merged

Fixing NuGetToolInstallerV0 #1793821 #14154

merged 1 commit into from
Dec 31, 2020

Conversation

@phil-hodgson
Copy link
Member

@phil-hodgson phil-hodgson commented Dec 31, 2020

Task name: NuGetToolInstallerV0

Description: Correctly handling msbuild versions

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) Y

Attached related issue: (Y/N) #1793821

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@phil-hodgson phil-hodgson self-assigned this Dec 31, 2020
@phil-hodgson phil-hodgson added the Area: ArtifactsPackages Azure Artifacts Packaging Team label Dec 31, 2020
magleaso
magleaso approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@magleaso magleaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phil-hodgson phil-hodgson merged commit b544b38 into master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magleaso magleaso magleaso approved these changes

@aasim aasim Awaiting requested review from aasim

@satbai satbai Awaiting requested review from satbai

Assignees

@phil-hodgson phil-hodgson

Labels

Area: ArtifactsPackages Azure Artifacts Packaging Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phil-hodgson @magleaso