-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace WMI query with interop #4723
Merged
aleksandrlevochkin
merged 14 commits into
master
from
users/levochkin/replace-wmi-query-with-interop
Apr 2, 2024
Merged
Replace WMI query with interop #4723
aleksandrlevochkin
merged 14 commits into
master
from
users/levochkin/replace-wmi-query-with-interop
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…s://github.com/microsoft/azure-pipelines-agent into users/levochkin/replace-wmi-query-with-interop
…s://github.com/microsoft/azure-pipelines-agent into users/levochkin/replace-wmi-query-with-interop
✅ Successfully linked to Azure Boards work item(s): |
DenisRumyantsev
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it. Changes work as expected. Looks good, thanks!
kirill-ivlev
approved these changes
Apr 1, 2024
DergachevE
reviewed
Apr 2, 2024
DergachevE
reviewed
Apr 2, 2024
DergachevE
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WI
AB#2142810
Description
When we turn on the
AZP_AGENT_CLEANUP_PSMODULES_IN_POWERSHELL
knob the WMI query times out for some machines.I added a new knob that allows to use interop to find parent processes.
Testing
Tested scenarios (in PS Core on Windows, for other platforms there should be no need to cleanup psmodules):
AZP_AGENT_CLEANUP_PSMODULES_IN_POWERSHELL: "true"
AZP_AGENT_USE_INTEROP_TO_FIND_PARENT_PROCESS: "false"
WMI query is used to determine if powershell is one of the parent processes.
AZP_AGENT_CLEANUP_PSMODULES_IN_POWERSHELL: "true"
AZP_AGENT_USE_INTEROP_TO_FIND_PARENT_PROCESS: "true"
Native Windows function is used to determine if powershell is one of the parent processes.