Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move condition result trace from result code to output #4371

Conversation

DenisRumyantsev
Copy link
Contributor

@DenisRumyantsev DenisRumyantsev commented Jul 26, 2023

Description: With this change, when a pipeline step is skipped due to its condition, the condition result trace will be written in the usual output instead of the result code. An improvement for the previous PR.

  • Logs on the UI side —
Skipping step due to condition evaluation.
  • Raw logs, pipeline debug mode is disabled —
2023-07-26T09:12:53.5462488Z Skipping step due to condition evaluation.
Evaluating: and(succeeded(), eq('true', 'false'))
Expanded: and(True, eq('true', 'false'))
Result: False
  • Raw logs, pipeline debug mode is enabled —
2023-07-26T09:36:40.2340286Z ##[debug]Evaluating condition for step: 'stepDisplayName'
2023-07-26T09:36:40.2344564Z ##[debug]Evaluating: and(succeeded(), eq('true', 'false'))
2023-07-26T09:36:40.2344922Z ##[debug]Evaluating and:
2023-07-26T09:36:40.2351490Z ##[debug]..Evaluating succeeded:
2023-07-26T09:36:40.2352773Z ##[debug]..=> True
2023-07-26T09:36:40.2353329Z ##[debug]..Evaluating eq:
2023-07-26T09:36:40.2355224Z ##[debug]....Evaluating String:
2023-07-26T09:36:40.2355948Z ##[debug]....=> 'true'
2023-07-26T09:36:40.2356516Z ##[debug]....Evaluating String:
2023-07-26T09:36:40.2356831Z ##[debug]....=> 'false'
2023-07-26T09:36:40.2361811Z ##[debug]..=> False
2023-07-26T09:36:40.2362468Z ##[debug]=> False
2023-07-26T09:36:40.2363908Z ##[debug]Expanded: and(True, eq('true', 'false'))
2023-07-26T09:36:40.2364203Z ##[debug]Result: False
2023-07-26T09:36:40.2365048Z Skipping step due to condition evaluation.
Evaluating: and(succeeded(), eq('true', 'false'))
Expanded: and(True, eq('true', 'false'))
Result: False

@DenisRumyantsev DenisRumyantsev requested review from a team as code owners July 26, 2023 09:21
@DenisRumyantsev DenisRumyantsev added the misc Miscellaneous Changes label Jul 26, 2023
@Pranshu-Negi Pranshu-Negi merged commit dbd6c82 into master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc Miscellaneous Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants