Fix SonarQube's "'Any()' should be used to test for emptiness" / Code…

src/Agent.Plugins/Artifact/FileContainerProvider.cs

@@ -95,7 +95,7 @@ private async Task DownloadFileContainerAsync(ArtifactDownloadParameters downloa
             tracer.Info($"Start downloading FCS artifact- {artifact.Name}");
             IEnumerable<Func<string, bool>> minimatcherFuncs = MinimatchHelper.GetMinimatchFuncs(minimatchPatterns, tracer);
 
-            if (minimatcherFuncs != null && minimatcherFuncs.Count() != 0)
+            if (minimatcherFuncs != null && minimatcherFuncs.Any())
             {
                 items = this.GetFilteredItems(items, minimatcherFuncs);
             }

src/Agent.Plugins/Artifact/PipelineArtifactServer.cs

@@ -158,7 +158,7 @@ internal async Task DownloadAsync(
                     }
 
                     IEnumerable<BuildArtifact> pipelineArtifacts = artifacts.Where(a => string.Equals(a.Resource.Type, PipelineArtifactConstants.PipelineArtifact, StringComparison.OrdinalIgnoreCase));
-                    if (pipelineArtifacts.Count() == 0)
+                    if (!pipelineArtifacts.Any())
                     {
                         throw new ArgumentException("Could not find any pipeline artifacts in the build.");
                     }

src/Agent.Sdk/ProcessInvoker.Windows.cs

@@ -134,7 +134,7 @@ private void WindowsKillProcessTree()
             Trace.Verbose($"Start killing process tree of process '{pid.Value}'.");
             Stack<ProcessTerminationInfo> processesNeedtoKill = new Stack<ProcessTerminationInfo>();
             processesNeedtoKill.Push(new ProcessTerminationInfo(pid.Value, false));
-            while (processesNeedtoKill.Count() > 0)
+            while (processesNeedtoKill.Any())
             {
                 ProcessTerminationInfo procInfo = processesNeedtoKill.Pop();
                 List<int> childProcessesIds = new List<int>();

src/Agent.Worker/Build/TrackingManager.cs

@@ -325,15 +325,15 @@ public void DisposeCollectedGarbage(IExecutionContext executionContext)
             }
 
             IEnumerable<string> gcTrackingFiles = Directory.EnumerateFiles(gcDirectory, "*.json");
-            if (gcTrackingFiles == null || gcTrackingFiles.Count() == 0)
+            if (gcTrackingFiles == null || !gcTrackingFiles.Any())
             {
                 executionContext.Output(StringUtil.Loc("GCDirIsEmpty", gcDirectory));
                 return;
             }
 
             Trace.Info($"Find {gcTrackingFiles.Count()} GC tracking files.");
 
-            if (gcTrackingFiles.Count() > 0)
+            if (gcTrackingFiles.Any())
             {
                 foreach (string gcFile in gcTrackingFiles)
                 {

src/Agent.Worker/CodeCoverage/CodeCoverageCommands.cs

@@ -67,7 +67,7 @@ public void Execute(IExecutionContext context, Command command)
             context.Output(StringUtil.Loc("ReadingCodeCoverageSummary", _summaryFileLocation));
             var coverageData = reader.GetCodeCoverageSummary(context, _summaryFileLocation);
 
-            if (coverageData == null || coverageData.Count() == 0)
+            if (coverageData == null || !coverageData.Any())
             {
                 context.Warning(StringUtil.Loc("CodeCoverageDataIsNull"));
             }
@@ -93,7 +93,7 @@ private async Task PublishCodeCoverageAsync(
             CancellationToken cancellationToken)
         {
             //step 2: publish code coverage summary to TFS
-            if (coverageData != null && coverageData.Count() > 0)
+            if (coverageData != null && coverageData.Any())
             {
                 commandContext.Output(StringUtil.Loc("PublishingCodeCoverage"));
                 foreach (var coverage in coverageData)

src/Agent.Worker/Release/ReleaseTrackingManager.cs

@@ -130,15 +130,15 @@ public void DisposeCollectedGarbage(IExecutionContext executionContext)
             }
 
             IEnumerable<string> gcTrackingFiles = Directory.EnumerateFiles(gcDirectory, "*.json");
-            if (gcTrackingFiles == null || gcTrackingFiles.Count() == 0)
+            if (gcTrackingFiles == null || !gcTrackingFiles.Any())
             {
                 executionContext.Output(StringUtil.Loc("GCReleaseDirIsEmpty", gcDirectory));
                 return;
             }
 
             Trace.Info($"Find {gcTrackingFiles.Count()} GC tracking files.");
 
-            if (gcTrackingFiles.Count() > 0)
+            if (gcTrackingFiles.Any())
             {
                 foreach (string gcFile in gcTrackingFiles)
                 {

src/Agent.Worker/TaskManager.cs

@@ -60,7 +60,7 @@ from task in tasks
                 into taskGrouping
                 select taskGrouping.First();
 
-            if (uniqueTasks.Count() == 0)
+            if (!uniqueTasks.Any())
             {
                 executionContext.Debug("There is no required tasks need to download.");
                 return;

src/Test/L0/Listener/CommandSettingsL0.cs

@@ -1153,7 +1153,7 @@ public void ValidateCommands()
                 var command = new CommandSettings(hc, args: new string[] { "badcommand" });
 
                 // Assert.
-                Assert.True(command.ParseErrors.Count() > 0);
+                Assert.True(command.ParseErrors.Any());
             }
         }
 
@@ -1168,7 +1168,7 @@ public void ValidateFlags()
                 var command = new CommandSettings(hc, args: new string[] { "--badflag" });
 
                 // Assert.
-                Assert.True(command.ParseErrors.Count() > 0);
+                Assert.True(command.ParseErrors.Any());
             }
         }
 
@@ -1183,7 +1183,7 @@ public void ValidateArgs()
                 var command = new CommandSettings(hc, args: new string[] { "--badargname", "bad arg value" });
 
                 // Assert.
-                Assert.True(command.ParseErrors.Count() > 0);
+                Assert.True(command.ParseErrors.Any());
             }
         }