Linux cancellation#322
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Can we have a descriptive constant here? This is the graceful cancel max time, correct?
TingluoHuang
force-pushed
the
users/tihuang/more
branch
3 times, most recently
from
aacf97a to
72bce83
Compare
| "runtimes": { | ||
| "win7-x64": { }, | ||
| "ubuntu.14.04-x64": { }, | ||
| "ubuntu.16.04-x64": { }, |
Contributor
There was a problem hiding this comment.
The PR looks good. Although I'm just curious why this is needed?
Contributor
There was a problem hiding this comment.
I think this was need to dev on ubuntu 16. We also need to drop an ubuntu 16 tar gz which I do want to do ...
Contributor
There was a problem hiding this comment.
I think right after this, we setup a 16 VM and start dropping that
TingluoHuang
force-pushed
the
users/tihuang/more
branch
from
9651c21 to
c6941a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.