Fix PH modifyEnvironment (#4287)

* interim fix * Correct args line * Remove debug log
microsoft · May 19, 2023 · 809ce0e · 809ce0e
1 parent 6e6a85c
commit 809ce0e
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/Agent.Worker/Handlers/ProcessHandler.cs b/src/Agent.Worker/Handlers/ProcessHandler.cs
@@ -137,8 +137,8 @@ public async Task RunAsync()
                 ? $"/c \"{_generatedScriptPath}"
                 : $"/c \"{command} {arguments}";
 
-            cmdExeArgs += _modifyEnvironment
-                ? " && echo {OutputDelimiter} && set \""
+            cmdExeArgs += _modifyEnvironment && !enableSecureArguments
+                ? $" && echo {OutputDelimiter} && set \""
                 : "\"";
 
             // Invoke the process.
@@ -211,9 +211,15 @@ private void GenerateScriptFile(string cmdExe, string command, string arguments)
             var agentTemp = ExecutionContext.GetVariableValueOrDefault(Constants.Variables.Agent.TempDirectory);
             _generatedScriptPath = Path.Combine(agentTemp, $"processHandlerScript_{scriptId}.cmd");
 
+            var scriptArgs = $"/v:ON /c \"{command} !{inputArgsEnvVarName}!";
+
+            scriptArgs += _modifyEnvironment
+            ? $" && echo {OutputDelimiter} && set \""
+            : "\"";
+
             using (var writer = new StreamWriter(_generatedScriptPath))
             {
-                writer.WriteLine($"{cmdExe} /v:ON /c \"{command} !{inputArgsEnvVarName}!\"");
+                writer.WriteLine($"{cmdExe} {scriptArgs}");
             }
 
             ExecutionContext.Debug($"Generated script file: {_generatedScriptPath}");