Improve test coverage #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Novaes
approved these changes
Aug 22, 2025
| expect(criteria).toHaveProperty("toolName", "CodeQL"); | ||
| expect(criteria).toHaveProperty("ref", "refs/heads/main"); | ||
| expect(criteria).toHaveProperty("onlyDefaultBranch", false); | ||
| }); |
There was a problem hiding this comment.
any way we can assert via a map here?
{
'ruleId': "rule123"
...
}
With fluentAssertions you should be able to do it.
| await handler(params); | ||
|
|
||
| expect(mockGetUserIdFromEmail).toHaveBeenCalledWith("john@example.com", tokenProvider, connectionProvider, userAgentProvider); | ||
| expect(mockGitApi.getPullRequests).toHaveBeenCalledWith("repo123", { status: PullRequestStatus.Active, repositoryId: "repo123", creatorId: "specific-user-123" }, undefined, undefined, 0, 100); |
There was a problem hiding this comment.
I'd move this payload outside here, hard to read this assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving test coverage with additional tests (generated by copilot).
Before
After
GitHub issue number
/
Associated Risks
/
✅ PR Checklist
🧪 How did you test it?
Executed tests.