test: add more test coverage for work items #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Novaes
approved these changes
Aug 13, 2025
| rel: "ArtifactLink", | ||
| url: "vstfs:///Build/Build/456", | ||
| attributes: { | ||
| name: "Found in build", |
There was a problem hiding this comment.
this object seem same as above. Can we just have a static factory for those in case we change the name newBuildAddOpExepctedResponse(name) or smth like this
| const [, , , handler] = call; | ||
|
|
||
| const mockWorkItem = { id: 1234, fields: { "System.Title": "Test Item" } }; | ||
| mockWorkItemTrackingApi.updateWorkItem.mockResolvedValue(mockWorkItem); |
There was a problem hiding this comment.
I'd move code to make //Given // When // Then, or // Given // When // Test // Verify meaning defining variables at first, then mocking, on test you can assert and on verify, verify it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add additional test coverage for missing code blocks in work items
GitHub issue number
Associated Risks
N/A
✅ PR Checklist
🧪 How did you test it?
re-run of automated tests