Skip to content

Conversation

kboom
Copy link
Contributor

@kboom kboom commented Jul 21, 2025

Search tools parameters were defined incorrectly, leading to either these parameters missing from MCP tools definition or to broken agentic workflows (in the case of wiki search). This also fixes the MCP inspector used through codespaces.

This fixes #296

Associated Risks

None

PR Checklist

  • I have read the contribution guidelines
  • I have read the code of conduct guidelines
  • Title of the pull request is clear and informative.
  • 👌 Code hygiene
  • 🔭 Telemetry added, updated, or N/A
  • 📄 Documentation added, updated, or N/A
  • 🛡️ Automated tests added, or N/A

🧪 How did you test it?

MCP inspector

@kboom kboom requested a review from a team as a code owner July 21, 2025 16:10
Copy link

github-actions bot commented Jul 21, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@aaudzei aaudzei merged commit 7cbd861 into main Jul 21, 2025
7 checks passed
@danhellem danhellem deleted the users/kboom/fix_search_tools branch August 13, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zod's .partial() cause MCP tool schema to be generated without the required properties array

4 participants