Repository navigation
fix: update test results fetching logic to support outcome validation… - #1684
Dan Hellem (danhellem) wants to merge 1 commit into
Conversation
… and improve concurrency handling
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Contract-level pre-merge test done - full report in #1682 (#1682 (comment)). Short version: the branch builds and starts clean (44 tools pinned vs 40 in the 2.10.0 release, the 4 extra coming from main, nothing removed), and the only input-schema change on the target tool is One release-note heads-up from that test: the enum silently rejects values the current release accepts (e.g. a lowercase The response fields themselves ( |
This pull request refactors the logic for fetching and filtering Azure DevOps test results for a build, improving both the implementation and its test coverage. The main changes include switching from a grouped-results API to explicit paging over test runs and results, enforcing stricter schema validation for test outcome filters, and updating the tests accordingly to verify the new behavior and edge cases.
Refactor and optimization of test results fetching:
test_results_from_build_idtool now fetches all test runs for a build and pages through their results directly, instead of relying on the grouped results API. This allows for more scalable and reliable result retrieval, especially for large builds.Schema and filtering improvements:
outcomesparameter is now strictly validated against the supported Azure DevOps test outcome values using az.enum, preventing unsupported outcome values from being passed. [1] [2]Test suite updates and enhancements:
Dependency and import updates:
GitHub issue number
#1682
Associated Risks
Changing response schema
✅ PR Checklist
🧪 How did you test it?
Ran thru several simple manual tests and asked copilot to verify. Updated automated tests