Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add hello app host #5445

Merged
merged 1 commit into from
Feb 8, 2025
Merged

re-add hello app host #5445

merged 1 commit into from
Feb 8, 2025

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Feb 8, 2025

the sun file got munched in a conflict resolution - removed it and readied it.

Why are these changes needed?

Related issue number

Checks

@rysweet rysweet requested a review from lokitoth February 8, 2025 01:24
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.16%. Comparing base (edbd201) to head (7dad735).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5445   +/-   ##
=======================================
  Coverage   76.16%   76.16%           
=======================================
  Files         196      196           
  Lines       10672    10672           
  Branches      139      139           
=======================================
  Hits         8128     8128           
  Misses       2449     2449           
  Partials       95       95           
Flag Coverage Δ
unittests 76.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rysweet rysweet enabled auto-merge (squash) February 8, 2025 02:17
@rysweet rysweet merged commit 51b601b into main Feb 8, 2025
67 checks passed
@rysweet rysweet deleted the rysweet-fix-apphostinsln branch February 8, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants