Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a root json element instead of dict #5430

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Use a root json element instead of dict #5430

merged 1 commit into from
Feb 7, 2025

Conversation

jackgerrits
Copy link
Member

No description provided.

@jackgerrits jackgerrits requested a review from bassmang February 7, 2025 15:51
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.48%. Comparing base (3c30d89) to head (4a123d5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Microsoft.AutoGen/Core.Grpc/GrpcAgentRuntime.cs 0.00% 3 Missing and 2 partials ⚠️
dotnet/src/Microsoft.AutoGen/Core/BaseAgent.cs 0.00% 1 Missing ⚠️
...net/src/Microsoft.AutoGen/Core/InProcessRuntime.cs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5430      +/-   ##
==========================================
- Coverage   78.08%   76.48%   -1.60%     
==========================================
  Files         158      192      +34     
  Lines        9576    10606    +1030     
  Branches        0      138     +138     
==========================================
+ Hits         7477     8112     +635     
- Misses       2099     2400     +301     
- Partials        0       94      +94     
Flag Coverage Δ
unittests 76.48% <41.66%> (-1.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgerrits jackgerrits merged commit 362d6a4 into main Feb 7, 2025
64 of 65 checks passed
@jackgerrits jackgerrits deleted the root_json_elem branch February 7, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants