Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proto descriptor for typename #5346

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Conversation

jackgerrits
Copy link
Member

Closes #5302

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.16%. Comparing base (6454e3f) to head (1c4ac25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5346      +/-   ##
==========================================
+ Coverage   76.15%   76.16%   +0.01%     
==========================================
  Files         158      158              
  Lines        9497     9502       +5     
==========================================
+ Hits         7232     7237       +5     
  Misses       2265     2265              
Flag Coverage Δ
unittests 76.16% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afourney afourney self-requested a review February 4, 2025 18:18
@jackgerrits jackgerrits enabled auto-merge (squash) February 4, 2025 19:13
@jackgerrits jackgerrits merged commit 40d74a3 into main Feb 4, 2025
63 checks passed
@jackgerrits jackgerrits deleted the serializer_type_name_proto branch February 4, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python should use protobuf descriptor as serializer typename
2 participants