[Core] Chore: fixed mypy issues for the function decorators #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
===========================================
+ Coverage 30.56% 40.90% +10.34%
===========================================
Files 30 30
Lines 4028 4034 +6
Branches 911 962 +51
===========================================
+ Hits 1231 1650 +419
+ Misses 2723 2256 -467
- Partials 74 128 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ekzhu
reviewed
Dec 28, 2023
ekzhu
approved these changes
Dec 28, 2023
ekzhu
changed the title
|
@davorrunje do you think we can perhaps wait for #974 to merge as that involves changes to function utils. |
|
@ekzhu of course, I'll merge with it and fix conflicts. |
|
Too many conflicts, I'll just redo it. |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Fix indentation in documentation * newline * version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Although the project is not checked by mypy, all mypy issues related to function decorators with a rather strict configuration are fixed.
Incorrect typing information causes problems for other developers using mypy to type-check their code. This is not limited to framework developers but to application developers as well.
Related issue number
Checks