This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Update Readme file in incorporate notes on ASP.NET container images o… #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirhatti
reviewed
Nov 29, 2018
README.md
Outdated
| FROM mcr.microsoft.com/dotnet/framework/aspnet:4.7.2-windowsservercore-ltsc2016 | ||
| … | ||
| ``` | ||
| As part of this transition, we are only changing the source from where you download your images to MCR. DockerHub continues to be the preferred medium for container image discovery. I encourage taking a look a [Steve Lasker’s blog post](https://azure.microsoft.com/en-us/blog/microsoft-syndicates-container-catalog/) taking about the value proposition we can offer our customers through MCR. |
There was a problem hiding this comment.
I don't like README linking out to blog posts that have point in time content. I'd take the salient points from there and include it in the readme if need be
There was a problem hiding this comment.
@shirhatti could please review the new content?
|
Can you also open a PR against MCR? The README doesn't automatically syndicate |
shirhatti
reviewed
Nov 29, 2018
README.md
Outdated
| ``` | ||
| As you may have noticed in the `docker pull` command, the image is now being served from the Microsoft Container Registry (MCR). Starting with Windows Server 2019 and going forwards, all new tags will be published exclusively to MCR. All existing tags have been syndicated from DockerHub to MCR. | ||
| If your existing Dockerfile begins by specifying microsoft/aspnet as the base layer as shown below- | ||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```Dockerfile |
shirhatti
reviewed
Nov 29, 2018
README.md
Outdated
| … | ||
| ``` | ||
| Our guidance is to move to adopting MCR as your base layer. You should change your Dockerfile to what’s shown below- | ||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```Dockerfile |
shirhatti
approved these changes
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Readme to incorporate notes of ASP.NET container images on Windows Server 2019.