Repository navigation
Improve display of Urls in main dashboard grid. - #20892
Draft
Alex Crome (afscrome) wants to merge 1 commit into
Draft
Alex Crome (afscrome) wants to merge 1 commit into
Alex Crome (afscrome) wants to merge 1 commit into
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20892Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20892" |
Alex Crome (afscrome)
changed the title
Alex Crome (afscrome)
changed the title
Contributor
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Contributor
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Contributor
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Fixes microsoft#11604. With multiple endpoints on a resource, showing the full URL as the link text gives no indication of which endpoint is which, and takes up excessive space when endpoints only differ by port. As a compromise between showing the full URL and just the endpoint name, default the display text to "{endpoint-name} ({port})" (e.g. "http (12345)") - callers can still override it via WithUrlForEndpoint/WithUrlDisplayName. Also: - Removes the aspire-dashboard resource's special-cased "Dashboard (http)" display text so it follows the same new default as every other resource. - Shows "{label}: {address}" in the Urls column's overflow popover (label is the display text, else the endpoint name, omitted if neither), since it isn't space-constrained the way the inline chips are. Only the address is the link; the label is plain text. - Renders every URL address as a link, including for schemes that aren't browsable such as tcp://. - In the resource details URLs table, the Address column always shows the real address (previously non-browsable URLs showed their display text) and the Text column is no longer a link. - Adds a stress playground showcase (AddUrlEndpointShowcaseResources) covering default/customized endpoints, URLs without an endpoint, and URLs pointing at another resource's endpoint, for both a clickable (http) and non-clickable (tcp) protocol. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Alex Crome (afscrome)
force-pushed
the
claude/endpoint-ui-display-format-3032c7
branch
from
October 11, 2026 07:55
dfeb504 to
dd3a75a
Compare
Contributor
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Contributor
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11604, based on some of the feedback on this.
The Urls column showed each URL's full address as its link text. For
*.dev.localhostURLs, such ashttp://my-resource-myapphost.dev.localhost:62482, that takes up almost all of the column, and when a resource has several endpoints the links all look alike so you can't tell which is which.Links now read
http (62482): the endpoint name and port. The port is kept because it is useful when troubleshooting, and the full address is still what you get on click or hover. Display text set by the app host (WithUrlForEndpoint,WithUrl(..., displayText)) still takes priority, and URLs that don't belong to an endpoint still show their address.The
+Noverflow popover has room for more, so each entry there readslabel: address(the label being the display text, or the endpoint name) and nothing is lost. The resource details URLs table always shows the real address in its Address column. Theaspire-dashboardresource no longer has its own special link text and looks like every other resource.To see it, run the Stress playground and look at the
url-endpoint-showcaseresource.Screenshots:
Before:
Truncation could often leave you with a lot of "duplicate" urls, with their differences hidden behidn the fold. You'd often only get a single url, even if you have multiple endpoints.
After:
On the dashboard grid, we now display
{displayText ?? endpointName} ({port}). This gets you the most critical information, in a fairly dense form, such that you can now see a few different endpoints without having to go to the more link. The view more link also shows both the display text and the raw url if you want easy access to hte raw url.Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate🤖 Generated with Claude Code