Repository navigation
[release/13.6] Recover ambiguous DCP creates with configurable timeouts - #20868
aspire-repo-bot[bot] wants to merge 1 commit into
Conversation
Confirm timed-out creates before retrying the same named object, bound create recovery, and share readiness-aware request deadlines across client setup and API operations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20868Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20868" |
Tests selector50 / 99 PR test projects · 4 PR jobs, from 5 changed files. Selected PR test projects (50 / 99)
Selected PR jobs (4)
How these were chosen — grouped by what changed
🔧 show 45
🧪 📦 affected project 🧪 Job reasons
Selection computed for commit |
| } | ||
| // Compare the remaining headroom rather than adding potentially overflowing configuration values. | ||
| else if (apiTimeoutValid && | ||
| options.KubernetesInitializationAdditionalTimeout > TimeSpan.FromMinutes(10) - options.KubernetesApiTimeout) |
There was a problem hiding this comment.
This one doesn't deserve a constant?
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
I think the tests are failing because we still need to rev the release to 13.6.2 now that 13.6.1 has shipped. The tests are failing due to an upgrade prompt since we're building 13.6.1 prerelease, but 13.6.1 stable is out. |
Backport of #20752 to release/13.6
/cc David Negstad (@danegsta)
Customer Impact
Adds retry and configurable timeout for DCP kubernetes API connections to mitigate timeouts some users have been seeing in 13.6.
Testing
Manual and automated testing
Risk
Low
Regression?
Yes. The issue was first reported with 13.6.