Skip to content

Update Azure.Provisioning.Cdn to beta.4 - #20855

Open
Eric Erhardt (eerhardt) wants to merge 2 commits into
mainfrom
eerhardt-update-azure-provisioning-cdn
Open

Eric Erhardt (eerhardt) wants to merge 2 commits into
mainfrom
eerhardt-update-azure-provisioning-cdn

Conversation

@eerhardt

Copy link
Copy Markdown
Member

Description

Update Azure.Provisioning.Cdn from 1.0.0-beta.2 to 1.0.0-beta.4. Beta.4 restores the expected Front Door resource-name requirements that regressed in beta.3, preserving the existing allowed characters and maximum name lengths. Also update Azure.Core to 1.63.0, the minimum required by the new CDN package.

Validation

dotnet test --project tests\Aspire.Hosting.Azure.Tests\Aspire.Hosting.Azure.Tests.csproj --no-launch-profile -- --filter-class "*.AzureFrontDoorTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true" — passed (13 tests).

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 581d6b70-779c-4cb6-b4a0-f5692777cac6
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20855

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20855"

@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot October 9, 2026 14:36
@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Oct 9, 2026
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 581d6b70-779c-4cb6-b4a0-f5692777cac6

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency versions are valid, naming behavior remains protected by snapshots, and no unresolved issues were found.

0 open findings

What changed in this PR

Updates Azure Front Door provisioning dependencies while preserving established resource naming behavior.

Changes:

  • Updates Azure.Provisioning.Cdn to beta.4 and Azure.Core to 1.63.0.
  • Refreshes Front Door Bicep snapshots for reordered properties.
  • Retains existing resource-name characters and length limits.
File Description
Directory.Packages.props Updates Azure package versions.
tests/​Aspire.Hosting.Azure.Tests/​Snapshots/​AzureFrontDoorTests.AddAzureFrontDoorWithSingleOriginGeneratesBicep.verified.bicep Updates single-origin property ordering.
tests/​Aspire.Hosting.Azure.Tests/​Snapshots/​AzureFrontDoorTests.AddAzureFrontDoorWithMultipleOriginsGeneratesBicep.verified.bicep Updates multiple-origin property ordering.

🧠 Review effort: Balanced


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Tests selector

Selects the full PR test matrix + all PR-gated jobs (ALL) — a rule matching 'Directory.Packages.props' selects ALL


Selection computed for commit 0855f9d.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The upstream fix preserves naming behavior, and the focused snapshots and test validation cover the dependency update.

0 open findings

🧠 Review effort: Balanced

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants