Skip to content

[release/13.6] Update Fluent UI to v5 RTM - #20545

Merged
Jose Perez Rodriguez (joperezr) merged 5 commits into
release/13.6from
manual-backport-20527-release-13.6
Oct 1, 2026
Merged

Jose Perez Rodriguez (joperezr) merged 5 commits into
release/13.6from
manual-backport-20527-release-13.6

Conversation

@JamesNK

Copy link
Copy Markdown
Member

Backport of #20527 to release/13.6

/cc James Newton-King (@JamesNK)

Customer Impact

Customers using the dashboard can encounter incorrect AppBar overflow styling and an unhandled navigation failure if the browser disconnects during a pending page-state update. This also brings the dashboard onto the Fluent UI v5 RTM APIs.

Testing

Repository restore; dashboard component test project build; 53 focused dashboard grid and resources tests; 5 focused normal, deferred, and disconnected-circuit mobile navigation tests; Windows x64 Native AOT dashboard publish; release dashboard build; and Playwright verification across expanded/collapsed layouts and light/dark themes.

Risk

Medium. This upgrades the shared Fluent UI dependency and adapts grid, navigation, and AppBar behavior, with focused component, publish, and browser validation covering the affected surfaces.

Regression?

No

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20545

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20545"

@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

Selects the full PR test matrix + all PR-gated jobs (ALL) — a rule matching 'Directory.Packages.props' selects ALL


Selection computed for commit 2e0a249.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The backport matches the source PR, preserves existing sorting behavior, and includes focused regression coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Backports Fluent UI v5 RTM support and related dashboard compatibility fixes to release/13.6.

Changes:

  • Upgrades Fluent UI components and icons to 5.0.0.
  • Migrates grid sorting to SortColumns.
  • Fixes AppBar styling and disconnected-circuit navigation handling with regression tests.
File Description
Directory.Packages.props Updates Fluent UI packages to v5 RTM.
src/​Aspire.Dashboard/​Components/​Controls/​Grid/​AspireFluentDataGrid.cs Adapts in-memory sorting to the v5 API.
src/​Aspire.Dashboard/​Components/​Layout/​MainLayout.razor.css Corrects AppBar overflow-button styling.
src/​Aspire.Dashboard/​Components/​Pages/​IPageWithSessionAndUrlState.cs Persists state before navigation and handles circuit disconnection.
src/​Aspire.Dashboard/​Components/​Pages/​Resources.razor.cs Uses the new sorting representation.
tests/​Aspire.Dashboard.Components.Tests/​Controls/​AspireFluentDataGridTests.cs Updates grid-provider tests for v5.
tests/​Aspire.Dashboard.Components.Tests/​Pages/​ResourcesTests.cs Updates sorting assertions and adds disconnect coverage.
tests/​Aspire.Dashboard.Components.Tests/​Shared/​ResourceSetupHelpers.cs Supports injecting session storage in tests.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@joperezr

Copy link
Copy Markdown
Member

Change looks good but let's hold off for now given the risk and the fact that 13.6 is about to ship. Let's keep it open for the first patch.

@joperezr Jose Perez Rodriguez (joperezr) added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 28, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 13.6 milestone Sep 29, 2026
@joperezr
Jose Perez Rodriguez (joperezr) merged commit 9415dbc into release/13.6 Oct 1, 2026
1266 of 1269 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot removed this from the 17.0 milestone Oct 1, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

✅ No documentation update needed.

Step 5 branch taken: excluded → base_branch_is_release, title_release_prefix, body_backport_marker

Exclusion reasons (from signals.json): This is a backport PR — base branch is release/13.6, title is prefixed [release/13.6], and the body contains an explicit backport marker ("Backport of #20527 to release/13.6"). Per workflow rules, backport PRs are out of scope for docs generation: their user-facing documentation is authored against the original forward PR (#20527) on the default branch, so drafting a second docs PR here would be duplicate noise.

Triggered signals: 1 (dashboard_user_facing_page_changed) — evidence: IPageWithSessionAndUrlState.cs and Resources.razor.cs match the dashboard page path pattern. However, since excluded == true, this overrides the recommendation and no further evaluation (including the ambiguity rule) applies.

No documentation PR was drafted.

This was referenced Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-dashboard NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants