Repository navigation
[release/13.6] Update Fluent UI to v5 RTM - #20545
Jose Perez Rodriguez (joperezr) merged 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20545Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20545" |
Tests selectorSelects the full PR test matrix + all PR-gated jobs (ALL) — a rule matching 'Directory.Packages.props' selects ALL Selection computed for commit |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The backport matches the source PR, preserves existing sorting behavior, and includes focused regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Backports Fluent UI v5 RTM support and related dashboard compatibility fixes to release/13.6.
Changes:
- Upgrades Fluent UI components and icons to 5.0.0.
- Migrates grid sorting to
SortColumns. - Fixes AppBar styling and disconnected-circuit navigation handling with regression tests.
| File | Description |
|---|---|
Directory.Packages.props |
Updates Fluent UI packages to v5 RTM. |
src/Aspire.Dashboard/Components/Controls/Grid/AspireFluentDataGrid.cs |
Adapts in-memory sorting to the v5 API. |
src/Aspire.Dashboard/Components/Layout/MainLayout.razor.css |
Corrects AppBar overflow-button styling. |
src/Aspire.Dashboard/Components/Pages/IPageWithSessionAndUrlState.cs |
Persists state before navigation and handles circuit disconnection. |
src/Aspire.Dashboard/Components/Pages/Resources.razor.cs |
Uses the new sorting representation. |
tests/Aspire.Dashboard.Components.Tests/Controls/AspireFluentDataGridTests.cs |
Updates grid-provider tests for v5. |
tests/Aspire.Dashboard.Components.Tests/Pages/ResourcesTests.cs |
Updates sorting assertions and adds disconnect coverage. |
tests/Aspire.Dashboard.Components.Tests/Shared/ResourceSetupHelpers.cs |
Supports injecting session storage in tests. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Change looks good but let's hold off for now given the risk and the fact that 13.6 is about to ship. Let's keep it open for the first patch. |
9415dbc
into
release/13.6
|
✅ No documentation update needed. Step 5 branch taken: Exclusion reasons (from signals.json): This is a backport PR — base branch is Triggered signals: 1 ( No documentation PR was drafted. |
Backport of #20527 to release/13.6
/cc James Newton-King (@JamesNK)
Customer Impact
Customers using the dashboard can encounter incorrect AppBar overflow styling and an unhandled navigation failure if the browser disconnects during a pending page-state update. This also brings the dashboard onto the Fluent UI v5 RTM APIs.
Testing
Repository restore; dashboard component test project build; 53 focused dashboard grid and resources tests; 5 focused normal, deferred, and disconnected-circuit mobile navigation tests; Windows x64 Native AOT dashboard publish; release dashboard build; and Playwright verification across expanded/collapsed layouts and light/dark themes.
Risk
Medium. This upgrades the shared Fluent UI dependency and adapts grid, navigation, and AppBar behavior, with focused component, publish, and browser validation covering the affected surfaces.
Regression?
No