Skip to content

Fix Autolinking for React Native 0.69 #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Naturalclar
Copy link
Contributor

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Moved podspec location to root directory of project as it is required for autolinking to work in react-native/cli v8
Also removed podspecPath from react-native.config as the parameter is deprecated, making autolink to fail

react-native-community/cli#1537

A few sentences describing the overall goals of the pull request.

Related PRs or issues

List related PRs and other issues.
#979

Misc

Add what's missing, notes on what you tested, additional thoughts or questions.

Copy link
Contributor

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that it will work with previous versions, so it's just TODO for reviewers: we must test it not only with 0.69

@sunchanras
Copy link

Any good news to update on this issue ?

@DmitriyKirakosyan
Copy link
Contributor

Hi @sunchanras , I'm currently testing it with different RN version. I confirm it works with RN 0.69 and it also looks working for pervious versions. I will merge it as soon as I'm sure it doesn't break anything.

@sunchanras
Copy link

@DmitriyKirakosyan Nice. Thank you.

@DmitriyKirakosyan
Copy link
Contributor

I've recreated this in #981, with a couple of tweaks. I'm closing it. Please follow the progress in #981.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants