Store rollouts posted to DevTaskLoader - #13
Merged
Yuge Zhang (ultmaster) merged 1 commit intoJul 24, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the DevTaskLoader by adding functionality to track and expose posted rollouts for debugging purposes. This change provides better visibility into rollouts during local development and testing.
- Adds a
posted_rolloutsproperty to DevTaskLoader for tracking submitted rollouts - Updates test assertions to verify rollouts are properly stored and accessible
- Reverts earlier test skipping changes for
examples/calc_x/test_agentops.py
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agentlightning/client.py | Adds private _posted_rollouts list and public posted_rollouts property, stores rollouts in post_rollout method |
| tests/test_client.py | Adds test assertions to verify rollouts are stored and accessible via the new property |
| else: | ||
| self._resources_update = ResourcesUpdate(resources_id="local", resources=resources) | ||
|
|
||
| # Store rollouts posted back to the loader for easy debugging of local runs |
There was a problem hiding this comment.
The _posted_rollouts attribute lacks documentation. Consider adding a docstring or inline comment explaining its purpose and lifecycle.
Suggested change
| # Store rollouts posted back to the loader for easy debugging of local runs | |
| # A list to store rollouts that have been posted back to the loader. | |
| # This is primarily used for debugging purposes during local runs. |
Yuge Zhang (ultmaster)
deleted the
codex/store-rollouts-in-devtaskloader
branch
October 28, 2025 01:18
euntaek hong (euntaek-hong)
pushed a commit
to wrongbutworks/agent-lightning
that referenced
this pull request
Aug 17, 2026
…vention, ordering discussion Decisions added: - microsoft#11: GSM8K 30-problem subset for math-poc dataset - microsoft#12: Image = environment, config.command = task selector - microsoft#13: Dockerfile.agent build context = examples/ - microsoft#5 updated: unified scripts/build_images.sh (bash, minikube) - 4a.6 updated: build_images.sh + .dockerignore
euntaek hong (euntaek-hong)
pushed a commit
to wrongbutworks/agent-lightning
that referenced
this pull request
Aug 17, 2026
…nd-resume fix: vllm pause and resume
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DevTaskLoaderposted_rolloutspropertyexamples/calc_x/test_agentops.pyTesting
pre-commit run --files agentlightning/client.py tests/test_client.py examples/calc_x/test_agentops.pypytest -q tests/test_client.pyhttps://chatgpt.com/codex/tasks/task_e_6882139f1b54832e87d9a5c487aec387