Skip to content

docs(adr): mark ADR-0030 accepted - #3890

Merged
MohammadHaroonAbuomar merged 1 commit into
microsoft:mainfrom
carloshvp:docs-accept-adr-0030
Sep 13, 2026
Merged

MohammadHaroonAbuomar merged 1 commit into
microsoft:mainfrom
carloshvp:docs-accept-adr-0030

Conversation

@carloshvp

@carloshvp Carlos Hernandez (carloshvp) commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • change ADR-0030 from proposed to accepted
  • refresh the ADR review date

Rationale

The Python implementation described by ADR-0030 landed through #3015, #3076,
#3096, #3097, #3100, and #3106. Maintainers closed the feature issue, #2478,
after confirming that scope was complete. Cross-SDK parity remains tracked
separately in #3083, as anticipated by the ADR migration plan.

The ADR index defines accepted as implemented, so the current proposed
label no longer reflects the shipped Python reference implementation.

PR #3891 owns the repository-wide index reconciliation, including the
ADR-0030 table move, so the two changes can merge in either order.

Validation

  • python3 scripts/docs/check_links.py
  • python3 scripts/docs/check_frontmatter.py --strict docs/adr/0030-action-bound-approval-protocol.md
  • changed-line cspell check
  • git diff --check

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions github-actions Bot added documentation Improvements or additions to documentation size/XS Extra small PR (< 10 lines) labels Sep 6, 2026
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

PR Review Summary

Check Status Details
🔍 Code Review ⚠️ Missing No current-run comment
🛡️ Security Scan ⚠️ Missing No current-run comment
🔄 Breaking Changes ⚠️ Missing No current-run comment
📝 Docs Sync ⚠️ Missing No current-run comment
🧪 Test Coverage ⚠️ Missing No current-run comment

Verdict: ⚠️ AI review incomplete; ready for human review

AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims.

Signed-off-by: Carlos Hernandez-Vaquero <carloshvp@gmail.com>

@MohammadHaroonAbuomar MohammadHaroonAbuomar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after group integration review (tests, gates and adversarial pass on the combined change).

@MohammadHaroonAbuomar
MohammadHaroonAbuomar merged commit 156a2c6 into microsoft:main Sep 13, 2026
86 checks passed
Karim Mehalebi (karimad) pushed a commit to karimad/agent-governance-toolkit that referenced this pull request Sep 14, 2026
Signed-off-by: Carlos Hernandez-Vaquero <carloshvp@gmail.com>
Yuvraj Singh (yuvrajsingh2428) pushed a commit to yuvrajsingh2428/agent-governance-toolkit that referenced this pull request Oct 1, 2026
Signed-off-by: Carlos Hernandez-Vaquero <carloshvp@gmail.com>
Signed-off-by: yuvrajsingh2428 <offcyuvi2428@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/XS Extra small PR (< 10 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants