Repository navigation
docs(security): add frontmatter to the #3524 fail-open audit note - #3619
Merged
liamcrumm merged 2 commits intoAug 12, 2026
Merged
Conversation
… note The 2026-07-31 fail-open closure audit doc merged in microsoft#3524 without a frontmatter block, but the strict frontmatter gate added in microsoft#3352 scans the whole tree (--root .). main therefore fails its own gate, and every open PR rebased onto main inherits the failure. Add the title/last_reviewed/owner block matching the sibling audit docs so `check_frontmatter.py --root . --strict` reports 0 findings. Signed-off-by: AlgoVoi <chopmob@gmail.com>
AlgoVoi (Christopher Hopley) (chopmob-cloud)
requested review from
MohammadHaroonAbuomar and
liamcrumm
as code owners
August 4, 2026 22:41
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
github-actions
Bot
added
documentation
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
Copilot started reviewing on behalf of
AlgoVoi (Christopher Hopley) (chopmob-cloud)
August 4, 2026 22:42
View session
|
🔴 Contributor Check: HIGH
Automated check by AGT Contributor Check. |
github-actions
Bot
added
the
needs-review:HIGH
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores the repository’s docs frontmatter invariant by adding the required YAML frontmatter block to the 2026-07-31 security audit note, unblocking the strict check_frontmatter.py --root . --strict CI gate that scans the full docs/ tree.
TL;DR: 0 blockers, 0 warnings. No issues found. Clean change.
Changes:
- Adds required docs YAML frontmatter (
title,last_reviewed,owner) to the affected audit doc. - Leaves the audit content unchanged beyond the metadata header.
Copilot started reviewing on behalf of
AlgoVoi (Christopher Hopley) (chopmob-cloud)
August 6, 2026 23:20
View session
1 task done
Contributor
|
it seems the workflows didn't kick off for this pr. I will close/reopen to retrigger workflows |
liamcrumm
approved these changes
Aug 12, 2026
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The strict docs-frontmatter gate added in #3352 scans the whole tree (
check_frontmatter.py --root . --strict). The fail-open closure audit doc merged in #3524 (docs/security/audits/2026-07-31-fail-open-closure-python-reference.md) has no frontmatter block, somainfails its own gate, and every open PR rebased onto currentmaininherits the "Validate docs frontmatter" failure.Fix
Add the
title/last_reviewed/ownerfrontmatter block, matching the sibling audit docs underdocs/security/audits/.Validation
Content below the header is unchanged.