Repository navigation
fix(core): widen cryptography upper bound to <51.0 - #3615
Merged
Merged
Conversation
The core metapackage's <50.0 cap is disjoint with the dependabot dev-extra widens to >=50.0 (#3607/#3610), so their test matrices die at pip install with ResolutionImpossible before a single test runs. Same shape as the 49-cycle widen (#3070). Compatibility evidence for 50.0.0: the full agent-mesh suite passes under cryptography 50 with this cap lifted (3601 passed; the two failures are sandbox-environment subprocess denials, not crypto), on top of the cloud-board/nexus verification from #3588 (85 tests; no applicable 49/50 breaking changes on Ed25519/AESGCM surfaces). Signed-off-by: MohammadHaroonAbuomar <40180927+MohammadHaroonAbuomar@users.noreply.github.com>
github-actions
Bot
added
dependencies
Dependency ReviewThe following issues were found:
License Issuesagent-governance-python/agent-governance-toolkit-core/pyproject.toml
OpenSSF Scorecard
Scanned Files
|
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
📦 Dependency diff (SBOM)Comparing main → mhabuomar/core-cryptography-51. ✅ No dependency changes detected. |
Contributor
There was a problem hiding this comment.
Pull request overview
Widens the cryptography upper bound in the agent-governance-toolkit-core Python meta-package to avoid dependency-resolution conflicts with related packages that have already moved their dev/test extras to cryptography>=50,<51.
Changes:
- Update
agent-governance-toolkit-coredependency constraint fromcryptography<50.0tocryptography<51.0to keep ranges compatible with the ongoing 50.x bump cycle.
Show a summary per file
| File | Description |
|---|---|
agent-governance-python/agent-governance-toolkit-core/pyproject.toml |
Widen cryptography upper bound to <51.0 to prevent disjoint constraints during install/CI resolution. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
liamcrumm
approved these changes
Aug 4, 2026
liamcrumm
pushed a commit
that referenced
this pull request
Aug 5, 2026
…together (#3621) Dependabot raised the two widens separately (#3607/#3610), but docker-compose-test co-installs every package, so each PR conflicts with the other package's still-capped <50.0 dev extra and neither can go green alone. Land both in one change; dependabot closes its PRs automatically once the manifests move. Compatibility evidence for 50.0.0 is already on record: full agent-mesh suite passes under 50 (3601 tests, incl. all 238 crypto-surface tests), cloud-board/nexus verified in the #3588 review, and the core/marketplace runtime caps were widened in #3615/#3604. Signed-off-by: MohammadHaroonAbuomar <40180927+MohammadHaroonAbuomar@users.noreply.github.com>
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The core metapackage caps
cryptography<50.0(pyproject.toml:46) while the open dependabot widens #3607/#3610 move the agent-mesh/agent-os dev extras to>=50.0.0,<51.0. The ranges are disjoint, so those PRs' test matrices fail atpip installwithResolutionImpossiblebefore any test executes. Same fix shape as #3070 (the 49-cycle widen).Compatibility evidence for cryptography 50.0.0
Unblock chain
@dependabot rebaseon chore(deps-dev): update cryptography requirement from <50.0,>=49.0.0 to >=50.0.0,<51.0 in /agent-governance-python/agent-mesh #3607/chore(deps-dev): update cryptography requirement from <50.0,>=49.0.0 to >=50.0.0,<51.0 in /agent-governance-python/agent-os #3610.Follow-up caps that will bite the same way in future cycles
agent-governance-toolkit-climcp extra<49.0;agent-mesh/packages/mcp-trust-server<47.0;agent-os/modules/iatp<50.0;agent-os/modules/nexus<44.0(stale — nexus itself was verified on 50). Left out of this PR to keep the diff minimal; happy to sweep them in a follow-up if preferred.