Repository navigation
Conversation
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
Dependency ReviewThe following issues were found:
|
📦 Dependency diff (SBOM)Comparing main → liamcrumm/retarget-acs-registry. Summary: ➕ 5 added · ➖ 19 removed · 🔄 10 bumped ➕ Added
|
| Package | Version |
|---|---|
| agent-control-spec | 0.4.0-alpha.3 |
| agent-hooks-sdk | 0.1.0-alpha.5 |
| ryu-js | 1.0.3 |
| ureq-proto | 0.6.1 |
| utf8-zero | 0.8.1 |
➖ Removed
cargo (19)
| Package | Version |
|---|---|
| anes | 0.1.6 |
| cast | 0.3.0 |
| ciborium | 0.2.2 |
| ciborium-io | 0.2.2 |
| ciborium-ll | 0.2.2 |
| criterion | 0.7.0 |
| criterion-plot | 0.6.0 |
| crossbeam-deque | 0.8.6 |
| crossbeam-epoch | 0.9.18 |
| crossbeam-utils | 0.8.21 |
| crunchy | 0.2.4 |
| half | 2.7.1 |
| oorandom | 11.1.5 |
| plotters | 0.3.7 |
| plotters-backend | 0.3.7 |
| plotters-svg | 0.3.7 |
| rayon | 1.12.0 |
| rayon-core | 1.13.0 |
| tinytemplate | 1.2.1 |
🔄 Bumped
cargo (3)
| Package | From | To |
|---|---|---|
| napi-build | 2.3.2 | 2.4.0 |
| portable-atomic | 1.13.1 | 1.14.0 |
| unicode-segmentation | 1.13.2 | 1.13.3 |
other (7)
| Package | From | To |
|---|---|---|
| agent-control-specification-node | 0.3.1-beta.0 | 0.4.0-beta.0 |
| agent_control_specification_annotators | 0.3.1-beta.0 | 0.4.0-beta.0 |
| agent_control_specification_mcp | 0.3.1-beta.0 | 0.4.0-beta.0 |
| agent_control_specification_openai | 0.3.1-beta.0 | 0.4.0-beta.0 |
| agent_control_specification_otel | 0.3.1-beta.0 | 0.4.0-beta.0 |
| agent_control_specification_py | 0.3.1-beta.0 | 0.4.0-beta.0 |
| agent_control_specification_rig | 0.3.1-beta.0 | 0.4.0-beta.0 |
5c99528 to
2928b89
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f040a65-a9b0-48a0-9ed3-c1384fbe0f00 Signed-off-by: Liam Crumm <liamcrumm@gmail.com>
Validate complete transformed snapshots across native bindings, standardize unresolved .NET approvals, repair native release assets, and require the versioned Python SDK throughout the dependency chain. Keep upstream ownership and remaining coordinated registry releases explicit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f040a65-a9b0-48a0-9ed3-c1384fbe0f00 Signed-off-by: Liam Crumm <liamcrumm@gmail.com>
Install local policy dependencies before integration, container and fuzz consumers; migrate manifests added on main; order ESRP PyPI publication and reject unsafe bulk GitHub uploads while retaining bulk dry-runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f040a65-a9b0-48a0-9ed3-c1384fbe0f00 Signed-off-by: Liam Crumm <liamcrumm@gmail.com>
Keep TLS restrictions, checksum verification and failure propagation while avoiding an unsupported retry option in the older fuzz image. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f040a65-a9b0-48a0-9ed3-c1384fbe0f00 Signed-off-by: Liam Crumm <liamcrumm@gmail.com>
Use a dated nightly toolchain for OSS-Fuzz's sanitizer flags, retain its Cargo coverage wrapper, and specify the native target so host proc macros are not instrumented. Verified the native wheel build with actual sanitizer flags in the pinned fuzz image. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f040a65-a9b0-48a0-9ed3-c1384fbe0f00 Signed-off-by: Liam Crumm <liamcrumm@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f040a65-a9b0-48a0-9ed3-c1384fbe0f00 Signed-off-by: Liam Crumm <liamcrumm@gmail.com>
Upgrade agent-control-spec to alpha.3 and agent-hooks-sdk to alpha.5 across all consumers. Preserve explicit OPA compatibility under Cargo feature unification, reuse public manifest/runtime APIs, and retain only behaviorally necessary compatibility surfaces. Verify registry provenance and aged HTTP dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f040a65-a9b0-48a0-9ed3-c1384fbe0f00 Signed-off-by: Liam Crumm <liamcrumm@gmail.com>
Keep the legacy array-typed version constant derived from upstream with a cardinality guard. Explicitly enable the lightweight OPA feature where alpha.3 otherwise fails to compile, and test the core shim and telemetry crate independently. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f040a65-a9b0-48a0-9ed3-c1384fbe0f00 Signed-off-by: Liam Crumm <liamcrumm@gmail.com>
Use the aged, hash-verified typing-extensions 4.16.0 release and test the sentinel API required by current AnyIO, avoiding the shared test lock's incompatible downgrade. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f040a65-a9b0-48a0-9ed3-c1384fbe0f00 Signed-off-by: Liam Crumm <liamcrumm@gmail.com>
Keep generator tests independent of application dependencies while exercising the exact AnyIO import that failed in the agent-os matrix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f040a65-a9b0-48a0-9ed3-c1384fbe0f00 Signed-off-by: Liam Crumm <liamcrumm@gmail.com>
|
Liam, this is next in line to land, but it's in merge conflict with main after today's merges. Could you rebase when you get a chance? I'll run the full re-review on the rebased head and land it; anything we find goes in a separate follow-up PR after yours is in. |
|
Liam, to land this today I've carried your branch onto main in #3939 (your commits unchanged, two small conflict resolutions described there, co-authored trailer for attribution). It runs through the full review group now; anything found goes in a follow-up PR after it merges. I'll close this one once #3939 is in. Shout if you'd rather take it back. |
…pec crate (microsoft#3939) Supersedes microsoft#3561. Carries liamcrumm's branch unchanged onto main; two conflict resolutions described in the PR. Co-authored-by: Liam Crumm <liamcrumm@gmail.com> Signed-off-by: MohammadHaroonAbuomar <40180927+MohammadHaroonAbuomar@users.noreply.github.com>
…pec crate (microsoft#3939) Supersedes microsoft#3561. Carries liamcrumm's branch unchanged onto main; two conflict resolutions described in the PR. Co-authored-by: Liam Crumm <liamcrumm@gmail.com> Signed-off-by: MohammadHaroonAbuomar <40180927+MohammadHaroonAbuomar@users.noreply.github.com> Signed-off-by: yuvrajsingh2428 <offcyuvi2428@gmail.com>
Summary
Replace AGT's embedded policy decision engine with
agent-control-spec =0.4.0-alpha.3andagent-hooks-sdk =0.1.0-alpha.5, the latest published pair verified September 8, while retaining AGT's existing host SDKs and native bindings. This is a breaking engine/host migration, not the six-package restructure.Problem
AGT maintains a second implementation of an extracted engine. ACS now returns a three-decision verdict; AGT must apply transforms, handle enforcement mode and approvals, and retain its legacy host result shape.
The September 8 reassessment also found release and compatibility defects in this branch. The latest commits merge current main, repair those defects, and distinguish pinned-engine limitations from functionality added in later ACS releases.
Changes
policy-engine/coreagent-control-spec =0.4.0-alpha.3. Derive the legacy array-typed constant from the public supported-version list with a cardinality guard; retain behaviorally necessary bounded validation, telemetry and identity helpers.host_error:approval_unresolved; version all five packages at0.4.0-beta.0.0.4.0b0; require it from the generator andagt-policies5.1.0. The consolidated core requiresagt-policies>=5.1.0,<6.0.0.4.0-alpha.1, manifest root$policy_targetto$target, and five-decision assumptions to the three-decision contract.All four direct ACS dependencies and all three consumer lockfiles use the updated registry pair. The crate checksum matches the registry and its trusted-publishing record. HTTP dependencies remain on aged
ureq3.4.0 /ureq-proto0.6.1 rather than their September 6 successors.Compatibility and rollout
warnbecomesallowwithwarnings[];escalatebecomes a liftabledenywithapproval.$policy_targetas an alias. The transform-path parser is a separate contract.0.4.0-alpha.1; manifests must not be bumped to the package version.AcsInterceptor/ActivatedPolicyconsumers follow ACS's feature selection. Enabling Rego elsewhere cannot silently switch the legacy host or C ABI.opafeature while keeping upstream defaults off, and are checked independently so workspace feature unification cannot hide this issue.opa,bundled-dispatchersfeature selection. It requires trusted manifests and transitive configuration. The default Rust SDK and production Python/Node builds do not enable bundled annotators.See
policy-engine/docs/acs-retarget.mdfor the symbol mapping and release order.Outstanding merge condition
The selected alpha.3 artifact has repository metadata and a trusted-publishing record bound to upstream commit
4c47b57033b98c0d2ccf1b94624f058815db0a9c. The review's remaining organization/team co-owner condition is not waived: the registry still lists one individual owner. Upstream responsibleai/agent-control-spec#24 remains open.The cooling-off scanner fix was split into #3564 and merged August 1. Its code is not changed here.
Pinned-engine limitations remain tracked upstream in responsibleai/agent-control-spec#20, #21, #22 and #23. The original binding-validation gap #14 was closed by #15; later releases expose more APIs, so the former blanket claim that bindings only expose
AcsInterceptoris no longer current.Testing
Local validation of the upstream upgrade:
-D warnings.core --no-default-features --libandotel --libchecks pass. The compatibility test also compiles the legacy supported-version constant as[&str; 1].pip checkand generates a valid manifest.Both independent reviewers confirmed their findings resolved with no new actionable issues at
aa25d0af. The legacy constant type and isolated no-backend builds have regression coverage, and the generated CI checks pass.The previous agent-os CI failure involved AnyIO 4.15.1 and the hashed test pin
typing-extensions==4.15.0; it was also present in the merged main baseline. Commitsf6b69289anded0f9bb3fix that mismatch with 4.16.0 and regression coverage. All three agent-os jobs now pass.Final verification at
ed0f9bb3: 151 checks pass, none fail and none are pending. Five checks are skipped/neutral, including the separate CodeQL comparison warning explained below. The small shared-dependency delta was directly reviewed; the earlier engine upgrade has clean independent reviews. The registry ownership condition is not waived, and the active Protect ruleset still requires a code-owner approval of the latest push. This is not yet a merge-ready verdict.CodeQL comparison warning
The missing default configuration is a separate Microsoft SDL API-upload analysis on main (48 rules, 54 findings), including custom rules not present in the standard Python/JavaScript workflow. It is not an empty duplicate and has not been deleted or replaced with a placeholder report. The current enforced required-status list does not include CodeQL; the existing workflow analyses are working. A matching SDL comparison needs the original publisher/query-pack access. The warning remains documented rather than hidden.
Attribution and AI assistance
Depends on the upstream engine extracted from this repository,
responsibleai/agent-control-spec, and theresponsibleai/agent-hookscontract. Written with GitHub Copilot CLI. No review comments or replies were posted as part of the September 8 maintenance.