Repository navigation
fix(agent-os): deepcopy context in YAML-match audit entry - #3037
Merged
Imran Siddique (imran-siddique) merged 1 commit intoJun 15, 2026
Merged
Conversation
The flat evaluator's rule-match branch set context_snapshot to the live context reference instead of a copy, leaving audit records sharing state with the caller. Every other branch already used copy.deepcopy; this one was missed in #3023. Fixes TestContextSnapshotIsolation::test_flat_yaml_match_isolated_from_top_level_mutation. Signed-off-by: Imran Siddique <imran.siddique@opaque.co>
Imran Siddique (imran-siddique)
requested a review
from MohammadHaroonAbuomar
as a code owner
June 15, 2026 20:42
🤖 AI Agent: breaking-change-detector — API Compatibility
API CompatibilityNo breaking changes detected. |
🤖 AI Agent: test-generator — `agent-governance-python/agent-os/src/agent_os/policies/evaluator.py`
|
🤖 AI Agent: security-scanner — View details
No security issues found. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
🤖 AI Agent: code-reviewer — View details
TL;DR: 0 blockers, 0 warnings. Fix ensures audit record isolation; clean change.
No action items required. Clean change. |
🤖 AI Agent: docs-sync-checker — Docs Sync
Docs SyncDocumentation is in sync. |
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
Imran Siddique (imran-siddique)
merged commit Jun 15, 2026
f401f19
into
main
127 of 131 checks passed
Imran Siddique (imran-siddique)
deleted the
fix/context-snapshot-yaml-match
branch
June 15, 2026 20:52
jlaportebot (jlaportebot)
pushed a commit
to jlaportebot/agent-governance-toolkit
that referenced
this pull request
Jun 17, 2026
…3037) The flat evaluator's rule-match branch set context_snapshot to the live context reference instead of a copy, leaving audit records sharing state with the caller. Every other branch already used copy.deepcopy; this one was missed in microsoft#3023. Fixes TestContextSnapshotIsolation::test_flat_yaml_match_isolated_from_top_level_mutation. Signed-off-by: Imran Siddique <imran.siddique@opaque.co> Signed-off-by: jlaportebot <jlaportebot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_evaluate_flat()setcontext_snapshotto the livecontextreference rather than a copybackend error,backend success,default action,exception) already calledcopy.deepcopy(context)— this one was missed when fix(agent-os): deep-copy context before storing as context_snapshot #3023 landedcontextwere visible inside the audit record, violating the isolation invariantTest
TestContextSnapshotIsolation::test_flat_yaml_match_isolated_from_top_level_mutationintests/test_folder_governance.pywas failing on all three Python versions. This commit makes it pass.Checklist
--signofffor DCO🤖 Generated with Claude Code